[Assimp] Add missing GenerateBoundingBoxes flag #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Todo
to In Progress
in Silk.NET Development Tracker
github-project-automation
bot
moved this from In Progress
to Done
in Silk.NET Development Tracker
Contributor
Author
|
Thank you! Have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This very simple PR merely adds the missing GenerateBoundingBoxes flag to Assimp that allows generating a mesh's Axis Aligned Bounding Box (AABB) on import, which is important in several use cases such as game engines to figure out the size of a mesh for collision or culling purposes.
Related issues, Discord discussions, or proposals
The flag's value can be found at https://github.com/assimp/assimp/blob/master/include/assimp/postprocess.h#L605
Further Comments
I believe this is an important flag to keep, and I'd love to have your feedback if you have any!